Remove invalid product type #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohmcruz
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
At a high level LGTM, only one concern. Are we confident this is not changing behaviour by potentially bundling things with different names in some scenarios that might not be covered on CI?
Specifically these values now map from
bundle_name, bundle_extension and executable_name <= bundling_support internal logicto
bundle_name <= ctx.attr.framework_name
bundle_extension <= ".framework"
executable_name <= bundle_nameHow to we know these names match before and after?
| @@ -582,7 +582,7 @@ def _merge_root_infoplists(ctx): | |||
| current_apple_platform = transition_support.current_apple_platform(apple_fragment = ctx.fragments.apple, xcode_config = ctx.attr._xcode_config) | |||
| platform_type = str(current_apple_platform.platform.platform_type) | |||
| apple_mac_toolchain_info = ctx.attr._toolchain[AppleMacToolsToolchainInfo] | |||
| rule_descriptor = rule_support.rule_descriptor(ctx) | |||
| rule_descriptor = rule_support.rule_descriptor_no_ctx(platform_type, apple_product_type.static_framework) | |||
There was a problem hiding this comment.
Right, in my other PR I could've passed the attribute we need directly like this 🤦, nice one
There was a problem hiding this comment.
NP @thiagohmcruz it just seemed like a small thing to fix up and make a bit easier
|
It'd be a decent amount of studying the code in general, but this is a lot more explicit and removes possible values for it which is a beneficial part of it too. |
It was previously hardcoded as as static library and led to confusion even though it was mainly unused at the time. Fixes #742
jerrymarino
force-pushed
the
jmarino/gut_framework_product_type
branch
from
bdd8d7c
to
9523862
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously hardcoded as as static library and led to confusion even though it was mainly unused at the time.
Fixes #742